RFR: 8287794: Reverse*VNode::Identity problem [v4]

Jatin Bhateja jbhateja at openjdk.org
Thu Jul 28 05:41:44 UTC 2022


On Thu, 28 Jul 2022 03:08:28 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8287794: Review comments resolved.
>
> test/hotspot/jtreg/compiler/vectorapi/TestReverseByteTransforms.java line 156:
> 
>> 154: 
>> 155:     @Test
>> 156:     @IR(applyIfCPUFeature={"sve", "true"}, failOn = {"ReverseBytesV" , " > 0 "})
> 
> Can we test the IR with x86 avx-512 predicated feature instead of "sve"? SVE is different that we also need to specify "-XX:UseSVE=1" to make sure the predicated feature enabled.

IR check is not applicable for AVX512,  test point is added to cover transform for SVE which supports direct predicated vector instruction. Feature checks are much more strict and "sve" feature will be available only if UseSVE is set to 1.

Thanks, removed redundant SVE check from IR annotations from other places.

-------------

PR: https://git.openjdk.org/jdk/pull/9623


More information about the hotspot-compiler-dev mailing list