RFR: 8287794: Reverse*VNode::Identity problem [v4]

[Xiaohong Gong]

On Thu, 28 Jul 2022 05:36:52 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/vectorapi/TestReverseByteTransforms.java line 156:
>> 
>>> 154: 
>>> 155:     @Test
>>> 156:     @IR(applyIfCPUFeature={"sve", "true"}, failOn = {"ReverseBytesV" , " > 0 "})
>> 
>> Can we test the IR with x86 avx-512 predicated feature instead of "sve"? SVE is different that we also need to specify "-XX:UseSVE=1" to make sure the predicated feature enabled.
>
> IR check is not applicable for AVX512,  test point is added to cover transform for SVE which supports direct predicated vector instruction. Feature checks are much more strict and "sve" feature will be available only if UseSVE is set to 1.
> 
> Thanks, removed redundant SVE check from IR annotations from other places.

Thanks for updating the tests! I ran the test in our internal testing system,  and unfortunately, this case will fail with "-XX:UseSVE=0" as expected. The reason is actually like what I said above. So to fix this, could you please:

1. Limit the whole test on aarch64 os systems by adding "`@requires vm.cpu.features ~= ".*simd.*"`" before the test. And limit the single IR test by adding "`applyIf={"UseSVE", ">0"}`" .

OR

2. Fix the IR framework, to make "applyIf" and "applyIfCPUFeature" can co-work with each other.

WDYT?

-------------

PR: https://git.openjdk.org/jdk/pull/9623