RFR: 8287001: Add warning message when fail to load hsdis libraries

[Cesar Soares]

On Thu, 19 May 2022 06:37:28 GMT, Yuta Sato <duke at openjdk.java.net> wrote:

> When failing to load hsdis(Hot Spot Disassembler) library (because there is no library or hsdis.so is old and so on),
> there is no warning message (only can see info level messages if put -Xlog:os=info).
> This should show a warning message to tell the user that you failed to load libraries for hsdis.
> So I put a warning message to notify this.
> 
> e.g.
> `

FWIW it seems to me that `load_library` is indeed the best place to print the message.

src/hotspot/share/compiler/disassembler.cpp line 841:

> 839:                                           os::dll_lookup(_library, decode_instructions_virtual_name));
> 840:   } else {
> 841:     log_warning(os)("Try to load hsdis library failed");

NIT: I suggest adding the name of the file that was searched for and rewording this message a bit: "Failed to load hsdis library: hsdis-x86.so"

-------------

PR: https://git.openjdk.java.net/jdk/pull/8782