RFR: 8287001: Add warning message when fail to load hsdis libraries [v2]
Yuta Sato
duke at openjdk.java.net
Wed Jun 1 06:18:36 UTC 2022
On Wed, 1 Jun 2022 00:46:03 GMT, Cesar Soares <duke at openjdk.java.net> wrote:
>> Yuta Sato has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add the name of file that was searched to warning message
>
> src/hotspot/share/compiler/disassembler.cpp line 841:
>
>> 839: os::dll_lookup(_library, decode_instructions_virtual_name));
>> 840: } else {
>> 841: log_warning(os)("Try to load hsdis library failed");
>
> NIT: I suggest adding the name of the file that was searched for and rewording this message a bit: "Failed to load hsdis library: hsdis-x86.so"
@JohnTortugo
Thank you for your advice !!
I added the name of the file to the warning message.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8782
More information about the hotspot-compiler-dev
mailing list