RFR: 8287001: Add warning message when fail to load hsdis libraries [v3]
Cesar Soares
duke at openjdk.java.net
Mon Jun 6 20:39:23 UTC 2022
On Wed, 1 Jun 2022 08:55:16 GMT, Yuta Sato <duke at openjdk.java.net> wrote:
>> @JohnTortugo
>> Thank you for your advice !!
>> I added the name of the file to the warning message.
>
> After I consider it, it might be better not to add the name of the file to this warning.
> If I look up code again, `Disassembler::load_library` checks all patterns of hsdis library
> like I commented here (https://github.com/openjdk/jdk/pull/8782#issuecomment-1132489576).
> Because of this, this warning message should be for telling that
> "you failed to load all patterns of hsdis library".
> So I reverted my last commit.
NIT: "Failed to load hsdis library." or "Loading hsdis library failed."
-------------
PR: https://git.openjdk.java.net/jdk/pull/8782
More information about the hotspot-compiler-dev
mailing list