RFR: 8287001: Add warning message when fail to load hsdis libraries [v3]
Yuta Sato
duke at openjdk.java.net
Wed Jun 1 08:58:27 UTC 2022
On Wed, 1 Jun 2022 06:15:37 GMT, Yuta Sato <duke at openjdk.java.net> wrote:
>> src/hotspot/share/compiler/disassembler.cpp line 841:
>>
>>> 839: os::dll_lookup(_library, decode_instructions_virtual_name));
>>> 840: } else {
>>> 841: log_warning(os)("Try to load hsdis library failed");
>>
>> NIT: I suggest adding the name of the file that was searched for and rewording this message a bit: "Failed to load hsdis library: hsdis-x86.so"
>
> @JohnTortugo
> Thank you for your advice !!
> I added the name of the file to the warning message.
After I consider it, it might be better not to add the name of the file to this warning.
If I look up code again, `Disassembler::load_library` checks all patterns of hsdis library
like I commented here (https://github.com/openjdk/jdk/pull/8782#issuecomment-1132489576).
Because of this, this warning message should be for telling that
"you failed to load all patterns of hsdis library".
So I reverted my last commit.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8782
More information about the hotspot-compiler-dev
mailing list