RFR: 8283775: better dump: VM support for graph querying in debugger with BFS traversal and node filtering [v29]

[Emanuel Peter]

On Tue, 7 Jun 2022 16:59:53 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply suggestions from code review from @TobiHartmann
>>   
>>   Thank you @TobiHartmann
>>   
>>   Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> src/hotspot/share/opto/node.cpp line 1997:
> 
>> 1995:   tty->print("      H: display this help info, with examples\n");
>> 1996:   tty->print("      +: traverse in-edges (on if neither + nor -)\n");
>> 1997:   tty->print("      -: traverse out-edges\n");
> 
> I would find it more natural if out-edges were also traversed by default, but it is a matter of taste.

I think I will keep it, as `dump` also by default only traverses in-edges.
Additionally, it can be quite confusing to traverse input and output edges at the same time.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8468