RFR: 8283775: better dump: VM support for graph querying in debugger with BFS traversal and node filtering [v29]

[Emanuel Peter]

On Tue, 7 Jun 2022 17:01:52 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply suggestions from code review from @TobiHartmann
>>   
>>   Thank you @TobiHartmann
>>   
>>   Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> src/hotspot/share/opto/node.cpp line 2310:
> 
>> 2308: // To find all options, run:
>> 2309: //   find_node(0)->dump_bfs(0,0,"H")
>> 2310: void Node::dump_bfs(const int max_distance, Node* target, char const* options) {
> 
> Would be great to have a short version `Node::dump_bfs(n)` equivalent to `Node::dump_bfs(n, 0, 0)`, for convenience.

great idea, I will do that!

> src/hotspot/share/opto/node.hpp line 1193:
> 
>> 1191:   Node* find(int idx, bool only_ctrl = false); // Search the graph for the given idx.
>> 1192:   Node* find_ctrl(int idx); // Search control ancestors for the given idx.
>> 1193:   void dump_bfs(const int max_distance, Node* target, char const* options); // Print BFS traversal
> 
> Suggestion: `char const* options` -> `const char* options` (same for the other occurrences in the changeset).

thanks, somehow I got the order a little messed up

-------------

PR: https://git.openjdk.java.net/jdk/pull/8468