RFR: 8283775: better dump: VM support for graph querying in debugger with BFS traversal and node filtering [v29]

[Emanuel Peter]

On Tue, 7 Jun 2022 17:07:26 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply suggestions from code review from @TobiHartmann
>>   
>>   Thank you @TobiHartmann
>>   
>>   Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> src/hotspot/share/opto/node.cpp line 2240:
> 
>> 2238:     tty->print("   _");
>> 2239:   } else {
>> 2240:     print_node_idx(b->head());
> 
> I think it would also be useful to print the block identifier, i.e. `print("B%d", b->_pre_order)`.

added it, thanks for the suggestion!

> src/hotspot/share/opto/node.cpp line 2278:
> 
>> 2276:   }
>> 2277:   if (_print_blocks) {
>> 2278:     tty->print(" [head  idom  d]");           // block
> 
> Perhaps rename the third block column `d` to something more descriptive (`depth` or similar) for clarity, that would also break the ambiguity with `d` which is already used for "distance".

I renamed d -> dist, and d -> depth. That should make things clearer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8468