RFR: 8263384: IGV: Outline should highlight the Graph that has focus
Xin Liu
xliu at openjdk.java.net
Thu Jun 16 07:16:12 UTC 2022
On Thu, 16 Jun 2022 07:07:24 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> This changeset eases navigation within and across graph groups by highlighting the focused graph in the Outline window. If the user changes the focus to another graph window, or moves to the previous or next graph within the same window, the newly focused graph is automatically highlighted in the Outline window. This is implemented by maintaining a static map from opened graphs to their corresponding [NetBeans nodes](https://netbeans.apache.org/tutorials/nbm-selection-2.html). The Outline window uses the map to select, on a graph focus change, the NetBeans node of the newly focused graph that should be highlighted.
>>
>> Tested manually by opening simultaneously tens of graphs from different groups and switching the focus randomly.
>
> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/FolderNode.java line 80:
>
>> 78: for (Node n : nodes) {
>> 79: // Each node is only present once in the graphNode map.
>> 80: graphNode.values().remove(n);
>
> Is `destroyNodes()` thread-safe here? graphNode is a HashMap instead of ConcurrentHashMap.
This method is by the inner class of RemoveCookie(). I am okay if the framwork guarantees to execute RemoveCookie sequentially.
-------------
PR: https://git.openjdk.org/jdk/pull/9167
More information about the hotspot-compiler-dev
mailing list