RFR: 8263384: IGV: Outline should highlight the Graph that has focus [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Thu Jun 16 10:22:35 UTC 2022


On Thu, 16 Jun 2022 07:13:49 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/FolderNode.java line 80:
>> 
>>> 78:             for (Node n : nodes) {
>>> 79:                 // Each node is only present once in the graphNode map.
>>> 80:                 graphNode.values().remove(n);
>> 
>> Is `destroyNodes()` thread-safe here? graphNode is a HashMap instead of ConcurrentHashMap.
>
> This method is by the inner class of RemoveCookie(). I am okay if the framwork guarantees to execute RemoveCookie sequentially.

This is guaranteed since `remove()` is called from the event dispatch thread.

-------------

PR: https://git.openjdk.org/jdk/pull/9167


More information about the hotspot-compiler-dev mailing list