RFR: 8263384: IGV: Outline should highlight the Graph that has focus [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Thu Jun 16 10:22:33 UTC 2022
> This changeset eases navigation within and across graph groups by highlighting the focused graph in the Outline window. If the user changes the focus to another graph window, or moves to the previous or next graph within the same window, the newly focused graph is automatically highlighted in the Outline window. This is implemented by maintaining a static map from opened graphs to their corresponding [NetBeans nodes](https://urldefense.com/v3/__https://netbeans.apache.org/tutorials/nbm-selection-2.html__;!!ACWV5N9M2RV99hQ!Mw4PI34f8wli3r-QHSz0QzAEBTmXpgFPWoBAIsW8Dxhk7uqBQ26lVRPb2YNL0_3lRQ2c2_rgMSDC5Pph8EMyGL6jFYW1X1JmJLFisA$ ). The Outline window uses the map to select, on a graph focus change, the NetBeans node of the newly focused graph that should be highlighted.
>
> Tested manually by opening simultaneously tens of graphs from different groups and switching the focus randomly.
Roberto Castañeda Lozano has updated the pull request incrementally with three additional commits since the last revision:
- Highlight active graph when the Outline window is re-opened
- Avoid unnecessary setting of 'result' to null
- Wait for last graph update before highlighting it
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9167/files
- new: https://git.openjdk.org/jdk/pull/9167/files/e4dd94c3..707827bf
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=9167&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=9167&range=00-01
Stats: 25 lines in 1 file changed: 15 ins; 7 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/9167.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9167/head:pull/9167
PR: https://git.openjdk.org/jdk/pull/9167
More information about the hotspot-compiler-dev
mailing list