RFR: 8263384: IGV: Outline should highlight the Graph that has focus [v2]

Xin Liu xliu at openjdk.org
Fri Jun 17 05:24:49 UTC 2022


On Thu, 16 Jun 2022 10:22:33 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> This changeset eases navigation within and across graph groups by highlighting the focused graph in the Outline window. If the user changes the focus to another graph window, or moves to the previous or next graph within the same window, the newly focused graph is automatically highlighted in the Outline window. This is implemented by maintaining a static map from opened graphs to their corresponding [NetBeans nodes](https://urldefense.com/v3/__https://netbeans.apache.org/tutorials/nbm-selection-2.html__;!!ACWV5N9M2RV99hQ!MfYW5ZqFu_p5aVwK0do4NlMNneXCiqCWHCQruk2fdW-4C8DqDWbpA6fu6NTwcTutDews_lYIWVaBoiagu-nFt0vWh7o$ ). The Outline window uses the map to select, on a graph focus change, the NetBeans node of the newly focused graph that should be highlighted.
>> 
>> Tested manually by opening simultaneously tens of graphs from different groups and switching the focus randomly.
>
> Roberto Castañeda Lozano has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Highlight active graph when the Outline window is re-opened
>  - Avoid unnecessary setting of 'result' to null
>  - Wait for last graph update before highlighting it

LGTM. I am not a review. Still need other reviewers approve it.

-------------

Marked as reviewed by xliu (Committer).

PR: https://git.openjdk.org/jdk/pull/9167


More information about the hotspot-compiler-dev mailing list