RFR: 8282547: IGV: add control-flow graph view [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.java.net
Wed Mar 23 08:47:39 UTC 2022


On Thu, 17 Mar 2022 08:38:07 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor code as suggested by Christian
>
> src/utils/IdealGraphVisualizer/Graph/src/main/java/com/sun/hotspot/igv/graph/FigureConnection.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2008, 2022, Oracle and/or its affiliates. All rights reserved.
> 
> Should only be 2022 for a new file.

This file is not really new, only renamed from the old `Connection.java` and slightly updated, hence I think it makes sense to leave the original initial year.

> src/utils/IdealGraphVisualizer/Graph/src/main/java/com/sun/hotspot/igv/graph/FigureConnection.java line 35:
> 
>> 33: /**
>> 34:  *
>> 35:  * @author Thomas Wuerthinger
> 
> You should take credit of this class instead ;-)

The file is not really new but renamed, I only updated it slightly, so I think the author tag is still relevant.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7817


More information about the hotspot-compiler-dev mailing list