RFR: 8282547: IGV: add control-flow graph view [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.java.net
Wed Mar 23 09:00:33 UTC 2022
On Wed, 16 Mar 2022 21:29:25 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Refactor code as suggested by Christian
>
> src/utils/IdealGraphVisualizer/Graal/src/main/java/com/sun/hotspot/igv/graal/filters/GraalEdgeColorFilter.java line 63:
>
>> 61: String type = null;
>> 62:
>> 63: if (type != null) {
>
> This block is dead since `type` is `null`. Is this intended?
I removed the method `Connection::getType()` and the code that depends on it in the Graal filters (the only place where this method was used). The Graal filters are not used and should just get removed, since HotSpot IGV does not support Graal anymore (a specific IGV variant is available for Graal, see https://www.graalvm.org/advanced-tools/). I will file a separate cleanup RFE for that.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7817
More information about the hotspot-compiler-dev
mailing list