RFR: 8282547: IGV: add control-flow graph view [v2]

[Roberto Castañeda Lozano]

On Wed, 16 Mar 2022 15:33:20 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor code as suggested by Christian
>
> src/utils/IdealGraphVisualizer/ServerCompiler/src/main/resources/com/sun/hotspot/igv/servercompiler/filters/hideExceptionBlocks.filter line 4:
> 
>> 2: 
>> 3: var f = new RemoveBlockFilter("Hide exception blocks");
>> 4: f.addRule(
> 
> Could the rule object directly be passed to the constructor instead of going over `addRule()`? On top of that, all filters follow the pattern "create f + `f.apply(graph)`". This could be moved into a single method to simplify filters. But this would exceed the scope of this change and could be done in a separate RFE.

A filter can consist of multiple rules, see e.g. `ServerCompiler/src/main/resources/com/sun/hotspot/igv/servercompiler/filters/structural.filter`, so I think it makes sense to pass them separately. What could be done to reduce this complexity is to define more helper methods in `Filter/src/main/resources/com/sun/hotspot/igv/filter/helper.js`. As you suggest, I think this would be best done for all filters at once in a separate RFE.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7817