RFR: 8282547: IGV: add control-flow graph view [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.java.net
Thu Mar 24 08:19:51 UTC 2022
On Wed, 23 Mar 2022 08:57:37 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> src/utils/IdealGraphVisualizer/Graal/src/main/java/com/sun/hotspot/igv/graal/filters/GraalEdgeColorFilter.java line 63:
>>
>>> 61: String type = null;
>>> 62:
>>> 63: if (type != null) {
>>
>> This block is dead since `type` is `null`. Is this intended?
>
> I removed the method `Connection::getType()` and the code that depends on it in the Graal filters (the only place where this method was used). The Graal filters are not used and should just get removed, since HotSpot IGV does not support Graal anymore (a specific IGV variant is available for Graal, see https://www.graalvm.org/advanced-tools/). I will file a separate cleanup RFE for that.
I just filed [JDK-8283612](https://bugs.openjdk.java.net/browse/JDK-8283612) for removing the Graal module.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7817
More information about the hotspot-compiler-dev
mailing list