RFR: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java

[Tobias Hartmann]

On Mon, 2 May 2022 14:08:57 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> The four test configurations for `compiler/stable/TestStableShort.java` are the same.
> 
> /*
>  * @test TestStableShort
>  * @summary tests on stable fields and arrays
>  * @library /test/lib /
>  * @modules java.base/jdk.internal.misc
>  * @modules java.base/jdk.internal.vm.annotation
>  * @build sun.hotspot.WhiteBox
>  *
>  * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
>  *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
>  *                                 -XX:-TieredCompilation
>  *                                 -XX:+FoldStableValues
>  *                                 compiler.stable.TestStableShort
>  * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
>  *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
>  *                                 -XX:-TieredCompilation
>  *                                 -XX:+FoldStableValues
>  *                                 compiler.stable.TestStableShort
>  *
>  * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
>  *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
>  *                                 -XX:-TieredCompilation
>  *                                 -XX:+FoldStableValues
>  *                                 compiler.stable.TestStableShort
>  * @run main/bootclasspath/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xcomp
>  *                                 -XX:CompileOnly=::get,::get1,::get2,::get3,::get4
>  *                                 -XX:-TieredCompilation
>  *                                 -XX:+FoldStableValues
>  *                                 compiler.stable.TestStableShort
>  */
> 
> 
> I believe this is a copy-paste mistake.
> Let's fix it.
> 
> The patch just follows the test configurations in TestStable{Byte/Char/Int/Long/Float/Double/Object}.java
> 
> Thanks.
> Best regards,
> Jie

Good catch, looks good to me. This was already reported by [JDK-8203318](https://bugs.openjdk.java.net/browse/JDK-8203318) but then the fix missed this test.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8503