RFR: 8283689: Update the foreign linker VM implementation [v17]

[Jorn Vernee]

On Fri, 13 May 2022 19:16:36 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 98 commits:
>> 
>>  - Merge branch 'master' into JEP-19-VM-IMPL2
>>  - Undo spurious changes.
>>  - Merge branch 'JEP-19-VM-IMPL2' of https://github.com/JornVernee/jdk into JEP-19-VM-IMPL2
>>  - Apply copyright year updates per request of @nick-arm
>>    
>>    Co-authored-by: Nick Gasson <nick.gasson at arm.com>
>>  - Fix overwritten copyright years.
>>  - Missed 2 years
>>  - Update Oracle copyright years
>>  - Revert "Block async exceptions during upcalls"
>>    
>>    This reverts commit b29ad8f46732666f2d07e63ce8701b1eb7bed790.
>>  - Block async exceptions during upcalls
>>  - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2
>>  - ... and 88 more: https://git.openjdk.java.net/jdk/compare/2c5d1362...f55b6c59
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5531:
> 
>> 5529: }
>> 5530: 
>> 5531: // On64 bit we will store integer like items to the stack as
> 
> Missing space.

Oh, looks like i deleted the wrong space by accident.

> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 933:
> 
>> 931:     } else {
>> 932:       assert(dst.is_single_reg(), "not a stack pair: (%s, %s), (%s, %s)",
>> 933:         src.first()->name(), src.second()->name(), dst.first()->name(), dst.second()->name());
> 
> Still not indented properly.

Shouldn't there be a 2-space indentation wrt the assert here? I could also indent all the arguments to be aligned with the format string, if that seems better.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7959