RFR: JDK-8297007: IGV: Link/Unlink node selection of open tabs

[Roberto Castañeda Lozano]

On Tue, 15 Nov 2022 15:37:26 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

> In IGV graphs can be opened in several tabs and then display them side-by-side. Previously, when the user selected nodes in tab A the selection was also applied in tab B. 
> 
> We now introduce a new global button to link and unlink the selection of different tabs.
> ![link_button](https://user-images.githubusercontent.com/71546117/201961318-e1263f6c-b3e9-41d5-a1f1-5493d5294bb5.png)
> 
> If the button is **pressed**, the selection is **linked** globally across tabs: 
> ![linked](https://user-images.githubusercontent.com/71546117/201960953-88f90c74-1c87-4c29-9881-47b55e7c26b9.png)
> 
> If the button is **not pressed**, the selection is **not linked** across tabs. This is the default setting:
> ![unlinked](https://user-images.githubusercontent.com/71546117/201961012-f531e7b9-1f23-4584-b207-02529ae25d5a.png)
> 
> # Implementation
> The `SelectionCoordinator` is responsible to update the other tabs when the selection changes. We simply disable the `SelectionCoordinator` when the link button is not pressed, and enable it otherwise.

Great improvement, this will really enable side-by-side viewing/exploration.

src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/GlobalSelectionAction.java line 2:

> 1: /*
> 2:  * Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.

Set new copyright year.

src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/GlobalSelectionAction.java line 32:

> 30: import javax.swing.ImageIcon;
> 31: import org.openide.util.ImageUtilities;
> 32: 

Would be nice to assign a shortcut to this action.

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11171