RFR: JDK-8297007: IGV: Link/Unlink node selection of open tabs [v2]

Tobias Holenstein tholenstein at openjdk.org
Thu Nov 17 13:11:14 UTC 2022


On Tue, 15 Nov 2022 18:44:28 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - add Shortcuts to GlobalSelectionAction
>>  - correct class in all CallableSystemAction
>>  - copyright year
>
> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/GlobalSelectionAction.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
> 
> Set new copyright year.

done

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/GlobalSelectionAction.java line 32:
> 
>> 30: import javax.swing.ImageIcon;
>> 31: import org.openide.util.ImageUtilities;
>> 32: 
> 
> Would be nice to assign a shortcut to this action.

Good idea. I added `Ctrl-L` (L for link?) as a shortcut. Since this is a global action, the shortcut will never be disabled.

-------------

PR: https://git.openjdk.org/jdk/pull/11171


More information about the hotspot-compiler-dev mailing list