RFR: JDK-8297007: IGV: Link/Unlink node selection of open tabs [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Thu Nov 17 13:49:20 UTC 2022
On Thu, 17 Nov 2022 13:11:11 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
>> In IGV graphs can be opened in several tabs and then display them side-by-side. Previously, when the user selected nodes in tab A the selection was also applied in tab B.
>>
>> We now introduce a new global button to link and unlink the selection of different tabs.
>> 
>>
>> If the button is **pressed**, the selection is **linked** globally across tabs:
>> 
>>
>> If the button is **not pressed**, the selection is **not linked** across tabs. This is the default setting:
>> 
>>
>> # Implementation
>> The `SelectionCoordinator` is responsible to update the other tabs when the selection changes. We simply disable the `SelectionCoordinator` when the link button is not pressed, and enable it otherwise.
>
> Tobias Holenstein has updated the pull request incrementally with three additional commits since the last revision:
>
> - add Shortcuts to GlobalSelectionAction
> - correct class in all CallableSystemAction
> - copyright year
Thanks for addressing my comments, Tobias!
-------------
Marked as reviewed by rcastanedalo (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11171
More information about the hotspot-compiler-dev
mailing list