RFR: JDK-8297007: IGV: Link/Unlink node selection of open tabs [v2]
Tobias Holenstein
tholenstein at openjdk.org
Thu Nov 17 13:11:11 UTC 2022
> In IGV graphs can be opened in several tabs and then display them side-by-side. Previously, when the user selected nodes in tab A the selection was also applied in tab B.
>
> We now introduce a new global button to link and unlink the selection of different tabs.
> 
>
> If the button is **pressed**, the selection is **linked** globally across tabs:
> 
>
> If the button is **not pressed**, the selection is **not linked** across tabs. This is the default setting:
> 
>
> # Implementation
> The `SelectionCoordinator` is responsible to update the other tabs when the selection changes. We simply disable the `SelectionCoordinator` when the link button is not pressed, and enable it otherwise.
Tobias Holenstein has updated the pull request incrementally with three additional commits since the last revision:
- add Shortcuts to GlobalSelectionAction
- correct class in all CallableSystemAction
- copyright year
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11171/files
- new: https://git.openjdk.org/jdk/pull/11171/files/f8cbc129..4accab3e
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11171&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11171&range=00-01
Stats: 85 lines in 13 files changed: 56 ins; 4 del; 25 mod
Patch: https://git.openjdk.org/jdk/pull/11171.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11171/head:pull/11171
PR: https://git.openjdk.org/jdk/pull/11171
More information about the hotspot-compiler-dev
mailing list