RFR: 8286302: Port JEP 425 to PPC64 [v7]

[Richard Reingruber]

On Tue, 22 Nov 2022 01:51:19 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup BasicExp test
>
> test/jdk/jdk/internal/vm/Continuation/BasicExp.java line 129:
> 
>> 127:  * @summary Collection of basic continuation tests. CompilationPolicy controls which frames in a sequence should be compiled when calling Continuation.yield().
>> 128:  * @requires vm.continuations
>> 129:  * @requires vm.flavor == "server" & (vm.opt.TieredCompilation == null | vm.opt.TieredCompilation == false)
> 
> Isn't vm.opt.TieredCompilation != true better?

Ah, sure.

> It is better to use tag @enablePreview so --enable-preview is not needed.

Done

> Also, please remove -XX:+UnlockDiagnosticVMOptions where it is not required.

The release build requires -XX:+UnlockDiagnosticVMOptions for -XX:+WhiteBoxAPI.

Without I get


Error: VM option 'WhiteBoxAPI' is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions.
Error: The unlock option must precede 'WhiteBoxAPI'.
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

> test/jdk/jdk/internal/vm/Continuation/BasicExp.java line 224:
> 
>> 222:         compPolicy.print(); System.out.println();
>> 223: 
>> 224:         new ContinuationRunYieldRunTest().runTestCase(3, compPolicy);
> 
> I think it would be better to split the test into several smaller testcases so timeout=300 is not needed. The fine granularity allows better parallelization of execution. The 5 minutes timeout means a very long-time test that couldn't be split.

Done

-------------

PR: https://git.openjdk.org/jdk/pull/10961