RFR: 8286302: Port JEP 425 to PPC64 [v7]

Leonid Mesnik lmesnik at openjdk.org
Tue Nov 22 18:47:49 UTC 2022


On Tue, 22 Nov 2022 17:24:09 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> test/jdk/jdk/internal/vm/Continuation/BasicExp.java line 136:
>> 
>>> 134:  * @run driver jdk.test.lib.helpers.ClassFileInstaller jdk.test.whitebox.WhiteBox
>>> 135:  *
>>> 136:  * @run main/othervm/timeout=300   --enable-preview -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbootclasspath/a:.
>> 
>> It is better to use tag @enablePreview so --enable-preview is not needed.
>> Also, please remove -XX:+UnlockDiagnosticVMOptions where it is not required.
>
>> It is better to use tag @enablePreview so --enable-preview is not needed.
> 
> Done
> 
>> Also, please remove -XX:+UnlockDiagnosticVMOptions where it is not required.
> 
> The release build requires -XX:+UnlockDiagnosticVMOptions for -XX:+WhiteBoxAPI.
> 
> Without I get
> 
> 
> Error: VM option 'WhiteBoxAPI' is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions.
> Error: The unlock option must precede 'WhiteBoxAPI'.
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.

Sorry, I meant -XX:+IgnoreUnrecognizedVMOptions where it is not needed. I think it is needed only to don't fail when -XX:+VerifyContinuations  is used in product mode and not needed in other testcases

-------------

PR: https://git.openjdk.org/jdk/pull/10961


More information about the hotspot-compiler-dev mailing list