RFR: 8297417: Poly1305IntrinsicFuzzTest fails with tag mismatch exception [v2]

Volodymyr Paprotski duke at openjdk.org
Wed Nov 23 22:43:22 UTC 2022


On Wed, 23 Nov 2022 22:33:05 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove rscratch from top regmap and ForceUnreachable test
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_poly.cpp line 562:
> 
>> 560:   const Register t1 = r14;
>> 561:   const Register t2 = r15;
>> 562:   const Register rscratch = r13;
> 
> After seeing the whole patch, I noticed that `t1` is used only at the very end of the stub. 
> 
> Alternatively, you could keep `rscratch` and move `t1` declaration close to the use sites.

No (unless I misunderstood), there are a couple more in the middle passed to `poly1305_multiply_scalar` (I prefer 'the look' of `t0, t1, t2`)


  poly1305_multiply_scalar(a0, a1, a2,
                           r0, r1, c1, true,
                           t0, t1, t2, mulql, mulqh);

-------------

PR: https://git.openjdk.org/jdk/pull/11308


More information about the hotspot-compiler-dev mailing list