RFR: 8297417: Poly1305IntrinsicFuzzTest fails with tag mismatch exception [v3]

[Vladimir Ivanov]

On Wed, 23 Nov 2022 22:41:01 GMT, Volodymyr Paprotski <duke at openjdk.org> wrote:

>> src/hotspot/cpu/x86/stubGenerator_x86_64_poly.cpp line 562:
>> 
>>> 560:   const Register t1 = r14;
>>> 561:   const Register t2 = r15;
>>> 562:   const Register rscratch = r13;
>> 
>> After seeing the whole patch, I noticed that `t1` is used only at the very end of the stub. 
>> 
>> Alternatively, you could keep `rscratch` and move `t1` declaration close to the use sites.
>
> No (unless I misunderstood), there are a couple more in the middle passed to `poly1305_multiply_scalar` (I prefer 'the look' of `t0, t1, t2`)
> 
> 
>   poly1305_multiply_scalar(a0, a1, a2,
>                            r0, r1, c1, true,
>                            t0, t1, t2, mulql, mulqh);

Yes, you are right. Overlooked those when browsed code on GitHub.

-------------

PR: https://git.openjdk.org/jdk/pull/11308