Integrated: JDK-8294567: IGV: IllegalStateException in search

Tobias Holenstein tholenstein at openjdk.org
Mon Oct 3 07:17:54 UTC 2022


On Thu, 29 Sep 2022 09:14:23 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

> When searching for a node, IGV first looks in the current open graph. If it can find the node here everything works fine. 
> 
> # Problem
> If if cannot find the node if uses the `searchForward` and `searchBackward` in the `EditorInputGraphProvider` to search in the other graphs. It crashes here because `editor.isOpened()` can only be called from the `EventDispatchThread`
> 
> # Solution
> The calls to `editor.isOpened()` are not needed because `editor != null` already means that it is open. So just remove all 4 calls to `editor.isOpened()`.

This pull request has now been integrated.

Changeset: 6e8f0387
Author:    Tobias Holenstein <tholenstein at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6e8f0387d64c9620bdd4c8913b2f41eade805348
Stats:     4 lines in 1 file changed: 0 ins; 0 del; 4 mod

8294567: IGV: IllegalStateException in search

Reviewed-by: rcastanedalo, chagedorn, kvn

-------------

PR: https://git.openjdk.org/jdk/pull/10483


More information about the hotspot-compiler-dev mailing list