RFR: JDK-8293480: IGV: Update Bytecode and ControlFlow Component immediately when opening a new graph [v2]

Tobias Holenstein tholenstein at openjdk.org
Thu Sep 8 12:40:36 UTC 2022


On Thu, 8 Sep 2022 11:45:45 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use multi-line lambdas
>
> src/utils/IdealGraphVisualizer/Bytecodes/src/main/java/com/sun/hotspot/igv/bytecodes/BytecodeViewTopComponent.java line 176:
> 
>> 174:         SwingUtilities.invokeLater(new Runnable() {
>> 175:             public void run() {
>> 176:                 final InputGraphProvider provider = LookupHistory.getLast(InputGraphProvider.class);
> 
> Suggestion: use a multi-line lambda for conciseness, like so:
> 
>         SwingUtilities.invokeLater(() -> {
>                 final InputGraphProvider provider = LookupHistory.getLast(InputGraphProvider.class);

done

> src/utils/IdealGraphVisualizer/ControlFlow/src/main/java/com/sun/hotspot/igv/controlflow/ControlFlowTopComponent.java line 142:
> 
>> 140:         SwingUtilities.invokeLater(new Runnable() {
>> 141:             public void run() {
>> 142:                 final InputGraphProvider provider = LookupHistory.getLast(InputGraphProvider.class);
> 
> Same suggestion as above.

done

> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/OutlineTopComponent.java line 153:
> 
>> 151:         SwingUtilities.invokeLater(new Runnable() {
>> 152:             public void run() {
>> 153:                 final InputGraphProvider provider = LookupHistory.getLast(InputGraphProvider.class);
> 
> Same suggestion as above.

done

-------------

PR: https://git.openjdk.org/jdk/pull/10196


More information about the hotspot-compiler-dev mailing list