RFR: JDK-8293480: IGV: Update Bytecode and ControlFlow Component immediately when opening a new graph [v4]

Tobias Holenstein tholenstein at openjdk.org
Fri Sep 9 13:10:59 UTC 2022


On Thu, 8 Sep 2022 11:53:40 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> Thanks for this UI improvement, Tobias, looks good to me! There is one more case where the Bytecode and Control Flow windows get out of sync: after removing all graphs and groups in the Outline, they still show the content of the graph that was last active:
> 
> ![bytecode-and-cfg-leftovers](https://user-images.githubusercontent.com/8792647/189114719-770ba617-e94c-4492-a5ab-81047b8a0b98.png)
> 
> This problem existed before the changeset, so it might be addressed here or in a separate issue, whatever you think makes more sense.

Thanks for spotting that  @robcasloz! I fixed it now. As a by-product of my fix, the `OutlineTopComponent` now also removes the graph selection when the corresponding `EditorTopComponent` was closed

-------------

PR: https://git.openjdk.org/jdk/pull/10196


More information about the hotspot-compiler-dev mailing list