RFR: JDK-8290011: IGV: Remove dead code and cleanup [v3]

Tobias Holenstein tholenstein at openjdk.org
Mon Sep 19 07:57:09 UTC 2022


On Thu, 8 Sep 2022 08:16:27 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   omit this
>>   
>>   Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> src/utils/IdealGraphVisualizer/Data/src/main/java/com/sun/hotspot/igv/data/InputNode.java line 34:
> 
>> 32: public class InputNode extends Properties.Entity {
>> 33: 
>> 34:     private int id;
> 
> While cleaning this class up anyways: Feels like a node id should probably not change anymore once it's set. Can this be turned into a `final` field? Looks like `setId()` is only called from this class and once from another class when creating a new input node anyways.

I think it is called in `Difference.java` as well: `n2.setId(curIndex);` , right?

-------------

PR: https://git.openjdk.org/jdk/pull/10197


More information about the hotspot-compiler-dev mailing list