RFR: 8294236: [IR Framework] CPU preconditions are overriden by regular preconditions

[Pengfei Li]

On Fri, 23 Sep 2022 07:55:15 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> This changeset ensures that all preconditions of a IR test (`applyIf`, `applyIfCPUFeature`, etc.) are evaluated as a logical conjunction to determine whether the test's IR check should be applied.
> 
> #### Testing
> 
> - tier1-3 (windows-x64, linux-x64, linux-aarch64, and macosx-x64).
> - IR framework tests in `test/hotspot/jtreg/testlibrary_tests/ir_framework` (linux-x64).

Thanks for your work. This is also what I'd like to do before.

IMO, it's better to evaluate `@applyIf` and `@applyIfCPUFeature` preconditions inside a single `@IR` check as a conjunction rather than a disjunction, because currently we don't have a chance to implement such conjunction. But after this change we can still implement a disjunction by writing multiple `@IR` checks for a single test method.

BTW, could you update the README file `test/hotspot/jtreg/compiler/lib/ir_framework/README.md` a bit so more test writers can be aware of this?

Generally LGTM. (Not a reviewer)

-------------

PR: https://git.openjdk.org/jdk/pull/10402