RFR: 8294236: [IR Framework] CPU preconditions are overriden by regular preconditions

Mon Sep 26 07:43:10 UTC 2022

On Mon, 26 Sep 2022 02:44:05 GMT, Pengfei Li <pli at openjdk.org> wrote:

> Thanks for your work. This is also what I'd like to do before.

> IMO, it's better to evaluate @applyIf and @applyIfCPUFeature preconditions inside a single @IR check as a conjunction rather > than a disjunction, because currently we don't have a chance to implement such conjunction. But after this change we can still > implement a disjunction by writing multiple @IR checks for a single test method.

Thanks for looking at this! I agree. Longer-term, I think the best option would be to unify all preconditions into a simple DSL as proposed in [JDK-8294279](https://bugs.openjdk.org/browse/JDK-8294279).

> BTW, could you update the README file test/hotspot/jtreg/compiler/lib/ir_framework/README.md a bit so more test writers can be aware of this?

Good point, done!

-------------

PR: https://git.openjdk.org/jdk/pull/10402