RFR: 8294236: [IR Framework] CPU preconditions are overriden by regular preconditions

[Christian Hagedorn]

On Fri, 23 Sep 2022 07:55:15 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> This changeset ensures that all preconditions of a IR test (`applyIf`, `applyIfCPUFeature`, etc.) are evaluated as a logical conjunction to determine whether the test's IR check should be applied.
> 
> #### Testing
> 
> - tier1-3 (windows-x64, linux-x64, linux-aarch64, and macosx-x64).
> - IR framework tests in `test/hotspot/jtreg/testlibrary_tests/ir_framework` (linux-x64).

Looks good, thanks for reporting and fixing that!

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPreconditions.java line 38:

> 36: 
> 37:     public static void main(String[] args) {
> 38:         TestFramework.runWithFlags("-XX:LoopMaxUnroll=8");

Since `LoopMaxUnroll` is a C2 only flag, you should add `@requires vm.compiler2.enabled`.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10402