RFR: JDK-8290011: IGV: Remove dead code and cleanup [v9]

Tobias Holenstein tholenstein at openjdk.org
Mon Sep 26 08:22:26 UTC 2022


On Thu, 8 Sep 2022 08:33:52 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more code cleanup
>
> src/utils/IdealGraphVisualizer/Graph/src/main/java/com/sun/hotspot/igv/graph/Diagram.java line 44:
> 
>> 42:     private static final Font font = new Font("Arial", Font.PLAIN, 12);
>> 43:     private static final Font slotFont = new Font("Arial", Font.PLAIN, 10);
>> 44:     private static final Font boldFont = font.deriveFont(Font.BOLD);
> 
> Maybe make them `public` and access them directly instead of going over `static` getters. Also, I suggest to use upper case letters for static final fields

done

-------------

PR: https://git.openjdk.org/jdk/pull/10197


More information about the hotspot-compiler-dev mailing list