RFR: JDK-8290011: IGV: Remove dead code and cleanup [v9]

Tobias Holenstein tholenstein at openjdk.org
Mon Sep 26 08:10:56 UTC 2022


On Thu, 8 Sep 2022 08:45:58 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more code cleanup
>
> src/utils/IdealGraphVisualizer/SelectionCoordinator/src/main/java/com/sun/hotspot/igv/selectioncoordinator/SelectionCoordinator.java line 52:
> 
>> 50:         highlightedChangedEvent = new ChangedEvent<SelectionCoordinator>(this);
>> 51:         selectedObjects = new HashSet<Object>();
>> 52:         highlightedObjects = new HashSet<Object>();
> 
> The explicit generic type argument can be omitted.

done for all code now

> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/actions/ShowAllAction.java line 43:
> 
>> 41:         EditorTopComponent editor = EditorTopComponent.getActive();
>> 42:         if (editor != null) {
>> 43:             editor.getModel().setHiddenNodes(new HashSet<Integer>());
> 
> Suggestion:
> 
>             editor.getModel().setHiddenNodes(new HashSet<>());

done

-------------

PR: https://git.openjdk.org/jdk/pull/10197


More information about the hotspot-compiler-dev mailing list