RFR: 8291801: IGV: Broken button "Hide graphs which are the same as the previous graph" [v2]

[Koichi Sakata]

On Wed, 28 Sep 2022 11:41:32 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Koichi Sakata has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Set value to hideDuplicates field
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8291801
>>  - Remove extra whitespaces
>>  - Improve the test
>>  - Add the test method
>>  - Remove extra code
>>  - Fix the broken button "Hide graphs which are the same as the previous graph" in IGV
>
> Hi Koichi, thank you very much for working on this!
> 
> Unfortunately, I cannot see the effect of your changes when I test them locally applied on top of the latest IGV change (commit e9401e67):
> 
> With "Hide graphs..." off (baseline):
> 
> ![hide-off](https://user-images.githubusercontent.com/8792647/192769480-d173a7b8-4dfe-4208-a035-b0a822eca4a0.png)
> 
> With "Hide graphs..." on (no graph is hidden):
> 
> ![hide-on-no-effect](https://user-images.githubusercontent.com/8792647/192769551-a0d3f44a-33ed-4acd-b3a5-413505dec0f4.png)
> 
> There seems to be some form of non-determinism. Sometimes, clicking on "Hide graphs..." does hide one or two graphs, e.g. 'Iter GVN 1' in this case:
> 
> 
> ![hide-on-one-hidden](https://user-images.githubusercontent.com/8792647/192769784-2ac06440-a6c4-45cd-a0c4-6dc3ea98d529.png)
> 
> or 'Iter GVN 1' and 'Incremental Inline' in this case:
> 
> ![hide-on-two-hidden](https://user-images.githubusercontent.com/8792647/192769833-9f67b318-1b35-41f8-8bd4-24f0b3ce36eb.png)
> 
> I hope this is reproducible in your environment as well, let me know if you need help reproducing it otherwise.

@robcasloz Thank you for your kind explanation. I can reproduce the bug that no graph is hidden. That happens when the point Tobias pointed out in this PR is not fixed. I've changed code quite recently. Would you mind applying the latest code and testing it again?

-------------

PR: https://git.openjdk.org/jdk/pull/10440