RFR: 8294236: [IR Framework] CPU preconditions are overriden by regular preconditions [v3]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Thu Sep 29 10:36:24 UTC 2022


> This changeset ensures that all preconditions of a IR test (`applyIf`, `applyIfCPUFeature`, etc.) are evaluated as a logical conjunction to determine whether the test's IR check should be applied.
> 
> #### Testing
> 
> - tier1-3 (windows-x64, linux-x64, linux-aarch64, and macosx-x64).
> - IR framework tests in `test/hotspot/jtreg/testlibrary_tests/ir_framework` (linux-x64).

Roberto Castañeda Lozano has updated the pull request incrementally with two additional commits since the last revision:

 - Use else-if, remove single-use Boolean variables, factor out duplicated code
 - Clarify comment in test case

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10402/files
  - new: https://git.openjdk.org/jdk/pull/10402/files/0f9881df..3e5f9d53

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10402&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10402&range=01-02

  Stats: 94 lines in 2 files changed: 29 ins; 64 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/10402.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10402/head:pull/10402

PR: https://git.openjdk.org/jdk/pull/10402


More information about the hotspot-compiler-dev mailing list