RFR: 8294236: [IR Framework] CPU preconditions are overriden by regular preconditions [v3]

Vladimir Kozlov kvn at openjdk.org
Thu Sep 29 17:50:23 UTC 2022


On Thu, 29 Sep 2022 10:36:24 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> This changeset ensures that all preconditions of a IR test (`applyIf`, `applyIfCPUFeature`, etc.) are evaluated as a logical conjunction to determine whether the test's IR check should be applied.
>> 
>> #### Testing
>> 
>> - tier1-3 (windows-x64, linux-x64, linux-aarch64, and macosx-x64).
>> - IR framework tests in `test/hotspot/jtreg/testlibrary_tests/ir_framework` (linux-x64).
>
> Roberto Castañeda Lozano has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Use else-if, remove single-use Boolean variables, factor out duplicated code
>  - Clarify comment in test case

Nice.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10402


More information about the hotspot-compiler-dev mailing list