RFR: JDK-8294567: IGV: IllegalStateException in search

Vladimir Kozlov kvn at openjdk.org
Thu Sep 29 17:59:18 UTC 2022


On Thu, 29 Sep 2022 09:14:23 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

> When searching for a node, IGV first looks in the current open graph. If it can find the node here everything works fine. 
> 
> # Problem
> If if cannot find the node if uses the `searchForward` and `searchBackward` in the `EditorInputGraphProvider` to search in the other graphs. It crashes here because `editor.isOpened()` can only be called from the `EventDispatchThread`
> 
> # Solution
> The calls to `editor.isOpened()` are not needed because `editor != null` already means that it is open. So just remove all 4 calls to `editor.isOpened()`.

I have general question (disclaimer: I did not use IGV for long time).
Is it possible to specify input data file when you launch IGV, run IGV in verification mode (load data, process/verify it, do some basic search and other manipulations) and exit?
We can then check result and catch cases like this bug.
Since we support this tool we should do some basic automatic testing for it.

-------------

PR: https://git.openjdk.org/jdk/pull/10483


More information about the hotspot-compiler-dev mailing list