RFR: JDK-8294567: IGV: IllegalStateException in search

[Tobias Holenstein]

On Thu, 29 Sep 2022 17:57:04 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> I have general question (disclaimer: I did not use IGV for long time).
> Is it possible to specify input data file when you launch IGV, run IGV in verification mode (load data, process/verify it, do some basic search and other manipulations) and exit?
> We can then check result and catch cases like this bug.
> Since we support this tool we should do some basic automatic testing for it.

Hi Vladimir, 
We have jUnit tests that are run every time we build IGV. But they are very basic at the moment and have poor coverage. I agree that the automated tests should be improved. Maybe we could start writing more jUnit tests. Ideally, we should also cover some more complex examples with the jUnit tests - like some kind of integration testing. For end-to-end testing (system testing), which is probably the scenario you describe, we do that by hand at the moment. The last time we did that was at https://github.com/openjdk/jdk/pull/10195 when we moved to Netbeans Platform 15. Automating this would be great - maybe there are frameworks that help with GUI testing, or we implement a "testing mode". For search, I am not sure yet how best to do this, except with jUnit tests for `searchForward()` and `searchBackward()`. They both are called in `EditorInputGraphProvider.java`, which is an `@ServiceProvider` in the Netbeans platform. `NodeQuickSearch.java` then uses the `InputGraphProvider` service. B
 ut neither `EditorInputGraphProvider.java` nor `NodeQuickSearch.java` is instantiated directly by us. Instead, we tell the Netbeans Platform in `view/layer.xml` that we want to use it for the search: `<file name="com-sun-hotspot-igv-view-NodeQuickSearch.instance"/>`.

-------------

PR: https://git.openjdk.org/jdk/pull/10483