RFR: JDK-8305356: Fix ignored bad CompileCommands in tests [v2]

Christian Hagedorn chagedorn at openjdk.org
Mon Apr 3 14:22:58 UTC 2023


On Mon, 3 Apr 2023 12:53:52 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> The following tests have a wrong `CompileCommand` and print an error message in `CompilerOracle::print_parse_error`: 
>> 
>> * missing `::*`:
>>    - `test/hotspot/jtreg/compiler/loopopts/TestPeelingRemoveDominatedTest.java` 
>> 
>> * used unsupported quotation marks `""`:
>>    - `test/hotspot/jtreg/compiler/integerArithmetic/TestNegMultiply.java` 
>>    - `test/hotspot/jtreg/compiler/integerArithmetic/TestNegAnd.java` 
>> 
>> * Use of the pattern `CompileCommand=option,Klass::method,type,option,value` but  `DisableIntrinsic`  has type option type `ccstrlist` and not `ccstr`:
>>    - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestMulAdd.java` 
>>    - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestMultiplyToLen.java` 
>>    - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestShift.java` 
>>    - `test/hotspot/jtreg/compiler/intrinsics/bigInteger/TestSquareToLen.java`
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   copyright year

Looks good!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13297#pullrequestreview-1369146072


More information about the hotspot-compiler-dev mailing list