RFR: 8305203: Simplify trimming operation in Region::Ideal [v2]

Xin Liu xliu at openjdk.org
Mon Apr 3 19:42:46 UTC 2023


On Mon, 3 Apr 2023 05:24:19 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update coding style according to reviewer's feedback.
>
> src/hotspot/share/opto/cfgnode.cpp line 576:
> 
>> 574: 
>> 575:         if(use->req() != req() && use->is_Phi()) {
>> 576:           assert(use->in(0) == this, "");
> 
> Suggestion:
> 
>           assert(use->in(0) == this, "unexpected control input");

updated. 

Could you help me submit this to your CI validation? TBH, I don't know why the original author starts over the loop. In my understanding, it doesn't delete any phi node but just put them into worklist.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13238#discussion_r1156381846


More information about the hotspot-compiler-dev mailing list