RFR: 8305203: Simplify trimming operation in Region::Ideal [v2]

[Tobias Hartmann]

On Mon, 3 Apr 2023 19:38:00 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> src/hotspot/share/opto/cfgnode.cpp line 576:
>> 
>>> 574: 
>>> 575:         if(use->req() != req() && use->is_Phi()) {
>>> 576:           assert(use->in(0) == this, "");
>> 
>> Suggestion:
>> 
>>           assert(use->in(0) == this, "unexpected control input");
>
> updated. 
> 
> Could you help me submit this to your CI validation? TBH, I don't know why the original author starts over the loop. In my understanding, it doesn't delete any phi node but just put them into worklist.

I did, all tests passed. I'm also not sure why that loop was there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13238#discussion_r1156835291