RFR: JDK-8305782: Provide MacroAssembler::breakpoint on aarch64 [v2]

[Andrew Haley]

On Tue, 11 Apr 2023 06:55:30 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> The ability to emit debug traps was useful for me on arm, and I miss it on aarch64.
>> 
>> Tested manually on Linux aarch64 in gdb with various values for hint covering the whole 16-bit range set. Hint gets encoded in the instruction (gdb decodes instruction as "BRK xxx" with xxx being the hint). According to documentation the hint ends up in ESR.ELx.ISS after the trap hit, but gdb refused to display the ESR register, so I could not verify that.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reuse Assembler::brk

src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 143:

> 141: }
> 142: 
> 143: void LIR_Assembler::breakpoint() { __ breakpoint(); }

Suggestion:

void LIR_Assembler::breakpoint() { __ brk(0); }


I don't think we need the rest of this patch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13401#discussion_r1162503145