RFR: JDK-8305782: Provide MacroAssembler::breakpoint on aarch64 [v2]

[Thomas Stuefe]

On Tue, 11 Apr 2023 08:54:24 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reuse Assembler::brk
>
> src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 143:
> 
>> 141: }
>> 142: 
>> 143: void LIR_Assembler::breakpoint() { __ breakpoint(); }
> 
> Suggestion:
> 
> void LIR_Assembler::breakpoint() { __ brk(0); }
> 
> 
> I don't think we need the rest of this patch.

"Assembler::breakpoint" does not require me to remember the concrete trap instruction on the platform I'm on. Otherwise, I need to remember brk(), illtrap(), emit(0xCC), ... etc. But right now, the only platform implementing this is Arm.

I don't have a lot of emotions here though. This is just a debugging aid.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13401#discussion_r1162879467