RFR: 8306331: assert((cnt > 0.0f) && (prob > 0.0f)) failed: Bad frequency assignment in if [v2]

Christian Hagedorn chagedorn at openjdk.org
Wed Apr 26 11:22:23 UTC 2023


On Mon, 24 Apr 2023 18:10:44 GMT, Dean Long <dlong at openjdk.org> wrote:

>> This change removes undefined behavior caused by signed overflow, which triggered an assert with Xcode14.3+1.0-beta1 on macos aarch64.
>
> Dean Long has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update src/hotspot/share/opto/parse2.cpp
>    
>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>  - Update src/hotspot/share/opto/parse2.cpp
>    
>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>

Looks good!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13551#pullrequestreview-1401750308


More information about the hotspot-compiler-dev mailing list