RFR: 8306966: RISC-V: Support vector cast node for Vector API [v3]

Gui Cao gcao at openjdk.org
Fri Apr 28 03:51:30 UTC 2023


On Fri, 28 Apr 2023 02:37:26 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Gui Cao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   During the conversion, specify the number of vectors
>
> src/hotspot/cpu/riscv/riscv_v.ad line 2837:
> 
>> 2835:     if (bt == T_LONG) {
>> 2836:       __ vector_integer_extend(as_VectorRegister($dst$$reg), T_LONG,
>> 2837:                                Matcher::vector_length_in_bytes(this), as_VectorRegister($dst$$reg), T_INT);
> 
> Will this work? I see you are asserting that 'dst' and 'src' vector registers are different in vector_integer_extend. But the same vector register is passed for these two paramerters here.

Fixed.

> src/hotspot/cpu/riscv/riscv_v.ad line 2885:
> 
>> 2883: %}
>> 2884: 
>> 2885: instruct vcvtDtoF(vReg dst_src1, vReg tmp) %{
> 
> Why not break down 'dst_src1' into two seperate 'dst' and 'src' inputs like you do for 'vcvtFtoD' ?

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13684#discussion_r1179896243
PR Review Comment: https://git.openjdk.org/jdk/pull/13684#discussion_r1179896145


More information about the hotspot-compiler-dev mailing list