RFR: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError [v3]

[Tobias Hartmann]

On Fri, 18 Aug 2023 10:19:13 GMT, Kimura Yukihiro <duke at openjdk.org> wrote:

>> I would like to fix this issue because it is difficult for testers to understand why the test failed.
>> There is no risk as I just added an assertion message instead of exit code error.
>> I would appreciate it if someone could review the fix.
>
> Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError

test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java line 63:

> 61:             // Ignore adapter creation failures
> 62:             if (!oa.getStderr().contains("Out of space in CodeCache for adapters")) {
> 63:                 throw new Exception("VM finished with exit code " + oa.getExitValue());

Please use `RuntimeException` like the code below does. I think you could also merge the two ifs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15329#discussion_r1298293757