RFR: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError [v3]

Kimura Yukihiro duke at openjdk.org
Fri Aug 18 14:12:51 UTC 2023


On Fri, 18 Aug 2023 10:29:07 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
>
> test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java line 63:
> 
>> 61:             // Ignore adapter creation failures
>> 62:             if (!oa.getStderr().contains("Out of space in CodeCache for adapters")) {
>> 63:                 throw new Exception("VM finished with exit code " + oa.getExitValue());
> 
> Please use `RuntimeException` like the code below does. I think you could also merge the two ifs.

Hello Tobias,

Thank you for pointing it out.
I have modified some points you had mentioned.

Thanks,
Kimura Yukihiro

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15329#discussion_r1298497653


More information about the hotspot-compiler-dev mailing list